Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3483
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e83342c with merge base c3d1680 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56401086 |
tarun292
added a commit
that referenced
this pull request
May 2, 2024
Summary: Pull Request resolved: #3483 This diff introduces the to_edge_transform_and_lower API. The changes introduces are: - Adding support to the Parititioner class to register ops that it doesn't want to be composed - Changes to _program.py to add the implementation of to_edge_transform_and_lower() - Added a basic test case to test that Linear, SDPA & Linear + SDPA are not decomposed when asked and the corresponding backend consumes them. Differential Revision: D56401086
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56401086 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56401086 |
tarun292
added a commit
that referenced
this pull request
May 2, 2024
Summary: Pull Request resolved: #3483 This diff introduces the to_edge_transform_and_lower API. The changes introduces are: - Adding support to the Parititioner class to register ops that it doesn't want to be composed - Changes to _program.py to add the implementation of to_edge_transform_and_lower() - Added a basic test case to test that Linear, SDPA & Linear + SDPA are not decomposed when asked and the corresponding backend consumes them. Differential Revision: D56401086
facebook-github-bot
pushed a commit
that referenced
this pull request
May 28, 2024
Summary: This diff introduces the to_edge_transform_and_lower API. The changes introduces are: - Adding support to the Parititioner class to register ops that it doesn't want to be composed - Changes to _program.py to add the implementation of to_edge_transform_and_lower() - Added a basic test case to test that Linear, SDPA & Linear + SDPA are not decomposed when asked and the corresponding backend consumes them. Reviewed By: kimishpatel, mcr229 Differential Revision: D56401086
facebook-github-bot
force-pushed
the
export-D56401086
branch
from
4ec6698 to
a414b5a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56401086 |
mcr229
approved these changes
May 28, 2024
tarun292
added a commit
that referenced
this pull request
May 28, 2024
Summary: This diff introduces the to_edge_transform_and_lower API. The changes introduces are: - Adding support to the Parititioner class to register ops that it doesn't want to be composed - Changes to _program.py to add the implementation of to_edge_transform_and_lower() - Added a basic test case to test that Linear, SDPA & Linear + SDPA are not decomposed when asked and the corresponding backend consumes them. Reviewed By: kimishpatel, mcr229 Differential Revision: D56401086
tarun292
force-pushed
the
export-D56401086
branch
from
a414b5a to
7f2de9b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56401086 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 28, 2024
Summary: This diff introduces the to_edge_transform_and_lower API. The changes introduces are: - Adding support to the Parititioner class to register ops that it doesn't want to be composed - Changes to _program.py to add the implementation of to_edge_transform_and_lower() - Added a basic test case to test that Linear, SDPA & Linear + SDPA are not decomposed when asked and the corresponding backend consumes them. Reviewed By: kimishpatel, mcr229 Differential Revision: D56401086
facebook-github-bot
force-pushed
the
export-D56401086
branch
from
7f2de9b to
ae0853e
Compare
Summary: This diff introduces the to_edge_transform_and_lower API. The changes introduces are: - Adding support to the Parititioner class to register ops that it doesn't want to be composed - Changes to _program.py to add the implementation of to_edge_transform_and_lower() - Added a basic test case to test that Linear, SDPA & Linear + SDPA are not decomposed when asked and the corresponding backend consumes them. Reviewed By: kimishpatel, mcr229 Differential Revision: D56401086
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56401086 |
tarun292
force-pushed
the
export-D56401086
branch
from
ae0853e to
e83342c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56401086 |
Contributor
|
This pull request has been merged in 2b91eba. |
This was referenced Sep 11, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Summary: ## Motivation Starting from iOS18, CoreML has added SDPA op, so there is no longer need to decompose torch SDPA ## Solution Following #3483, add `ops_not_to_decompose` in CoreML partitioner, then use `to_edge_transform_and_lower` API in llama export Pull Request resolved: #5258 Reviewed By: kirklandsign Differential Revision: D62550916 Pulled By: cccclai fbshipit-source-id: bc238a04ea9eb38341157cd2388b7cd17a506bf1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces the to_edge_transform_and_lower API. The changes introduces are:
Differential Revision: D56401086